Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挰 [RUMF-1605] Improve heavy customer data warning message #2316

Merged
merged 1 commit into from Jul 7, 2023

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Jul 3, 2023

Motivation

When passing a large amount of data in global context, user info or feature flags (>3KiB) the browser SDK prints a warning. The warning was confusing and brought lot of question for customers.

Changes

Before

The user data is over 3KiB. On low connectivity, the SDK has the potential to exhaust the user's upload bandwidth.

After

The user data exceeds the recommended 3KiB threshold. More details: https://docs.datadoghq.com/real_user_monitoring/browser/troubleshooting/#customer-data-exceeds-the-recommended-3kib-warning

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner July 3, 2023 09:42
@amortemousque amortemousque changed the title Improve heavy customer data warning message [RUMF-1605] Improve heavy customer data warning message Jul 3, 2023
@amortemousque amortemousque changed the title [RUMF-1605] Improve heavy customer data warning message 馃挰 [RUMF-1605] Improve heavy customer data warning message Jul 3, 2023
@amortemousque amortemousque merged commit 5b05ad0 into main Jul 7, 2023
17 checks passed
@amortemousque amortemousque deleted the aymeric/update-customer-data-warning branch July 7, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants