Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 [RUM-238] Handle tracekit multilines message parsing #2332

Merged
merged 4 commits into from
Jul 11, 2023
Merged

馃悰 [RUM-238] Handle tracekit multilines message parsing #2332

merged 4 commits into from
Jul 11, 2023

Conversation

amortemousque
Copy link
Contributor

Motivation

The tracekit error message parsing fails when the message contains new lines (\n)

Changes

Update the tracekit ERROR_TYPES_RE regex to handle new lines.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner July 11, 2023 08:52
bcaudan
bcaudan approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amortemousque amortemousque merged commit 7b04829 into main Jul 11, 2023
17 checks passed
@amortemousque amortemousque deleted the aymeric/fix-tracekit-parse-message branch July 11, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

@bcaudan bcaudan bcaudan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@amortemousque @BenoitZugmeyer @bcaudan