Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Cherry-pick some changes from v5 to limit conflicts #2357

Merged
merged 7 commits into from Jul 31, 2023

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Jul 27, 2023

Motivation

Limit conflicts with v5 while it is not yet ready to be released

Changes

Cherry pick and tweak some commits from #2308 and #2347 to:

  • use createNewEvent in tests
  • add a dependency on configuration for addEventListener

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan marked this pull request as ready for review July 27, 2023 12:14
@bcaudan bcaudan requested review from a team as code owners July 27, 2023 12:14
@codecov-commenter
Copy link

Codecov Report

Merging #2357 (98ec2e0) into main (322bfe2) will decrease coverage by 0.10%.
The diff coverage is 93.23%.

@@            Coverage Diff             @@
##             main    #2357      +/-   ##
==========================================
- Coverage   94.01%   93.92%   -0.10%     
==========================================
  Files         209      209              
  Lines        6232     6238       +6     
  Branches     1380     1383       +3     
==========================================
  Hits         5859     5859              
- Misses        373      379       +6     
Files Changed Coverage Δ
packages/core/test/emulate/createNewEvent.ts 80.00% <ø> (ø)
packages/rum-core/src/domain/assembly.ts 100.00% <ø> (ø)
...s/rum-core/src/domain/contexts/pageStateHistory.ts 82.60% <ø> (-10.87%) ⬇️
...in/rumEventsCollection/action/trackClickActions.ts 98.31% <ø> (ø)
packages/rum-core/src/transport/startRumBatch.ts 82.14% <ø> (ø)
...ckages/rum/src/domain/segmentCollection/segment.ts 98.03% <ø> (ø)
...ages/rum-core/src/browser/performanceCollection.ts 52.04% <36.36%> (ø)
packages/rum/src/boot/startRecording.ts 86.95% <50.00%> (-3.96%) ⬇️
...ckages/core/src/transport/startBatchWithReplica.ts 81.81% <66.66%> (ø)
packages/core/src/browser/addEventListener.ts 100.00% <100.00%> (ø)
... and 41 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bcaudan bcaudan merged commit a96f214 into main Jul 31, 2023
16 of 17 checks passed
@bcaudan bcaudan deleted the bcaudan/cherry-pick-v5-conflicts branch July 31, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants