✨ [extension] filter outdated events #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2023
BenoitZugmeyer
changed the title
BenoitZugmeyer
force-pushed
the
benoit/extension--group-view-updates
branch
2 times, most recently
from
f12e447
to
3d7ca67
Compare
amortemousque
approved these changes
Aug 25, 2023
bcaudan
reviewed
Aug 25, 2023
developer-extension/src/panel/hooks/useEvents/eventCollection.ts
Outdated
Show resolved
Hide resolved
bcaudan
reviewed
Aug 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #2369 +/- ##
==========================================
- Coverage 93.96% 93.94% -0.02%
==========================================
Files 210 210
Lines 6242 6242
Branches 1387 1387
==========================================
- Hits 5865 5864 -1
- Misses 377 378 +1 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I want to use the "event source" concept to differentiate between RUM, Logs, Telemetry and Session Replay. Also, eventCollectionStrategy is a bit more explicit.
* The `id` property from "StoredEvent" type was only useful for rendering purposes. This commit moves the computation of such rendering key in the component where it is used. * The `isRumEvent` was implemented twice, so this commit factorize it * The "telemetry" event source was considered as a RUM event, but the logs SDK can also generate such event. This is now an independent source.
BenoitZugmeyer
force-pushed
the
benoit/extension--group-view-updates
branch
from
3d16c15
to
410f328
Compare
|
Current dependencies on/for this PR:
This comment was autogenerated by Freephite. |
bcaudan
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Showing each View update is confusing as it can be seen as separate view events.
Changes
Before:
After:
Outdated view updates are hidden
View updates are collocated
Testing
I have gone over the contributing documentation.