Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scrollmap experimental flag #2374

Merged
merged 1 commit into from Aug 16, 2023

Conversation

hamza-kadiri
Copy link
Contributor

@hamza-kadiri hamza-kadiri commented Aug 10, 2023

Motivation

Remove scrollmap experimental flag

Changes

All customers will now send scroll data by default

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@hamza-kadiri hamza-kadiri requested a review from a team as a code owner August 10, 2023 14:41
@codecov-commenter
Copy link

Codecov Report

Merging #2374 (74335d4) into main (c3872d1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2374      +/-   ##
==========================================
+ Coverage   93.90%   93.93%   +0.02%     
==========================================
  Files         209      209              
  Lines        6238     6235       -3     
  Branches     1383     1381       -2     
==========================================
- Hits         5858     5857       -1     
+ Misses        380      378       -2     
Files Changed Coverage Δ
...omain/rumEventsCollection/view/trackViewMetrics.ts 98.13% <100.00%> (+1.76%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hamza-kadiri hamza-kadiri merged commit 3425bbf into main Aug 16, 2023
17 checks passed
@hamza-kadiri hamza-kadiri deleted the hamza/remove-scrollmap-experimental-flag branch August 16, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants