Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [RUM-1013] early exit when no configuration provided #2417

Merged
merged 1 commit into from Sep 7, 2023
Merged

✨ [RUM-1013] early exit when no configuration provided #2417

merged 1 commit into from Sep 7, 2023
+20 −0

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Sep 6, 2023

Motivation

telemetry errors are generated when SDK init are called without configuration.

Changes

When no init configuration is provided:

  • display error message
  • early exit

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner September 6, 2023 12:44
@bcaudan bcaudan merged commit b60cb44 into main Sep 7, 2023
17 checks passed
@bcaudan bcaudan deleted the bcaudan/missing-init-config branch September 7, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

@amortemousque amortemousque amortemousque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcaudan @BenoitZugmeyer @amortemousque