♻️ [RUM-2445] do not buffer early recorder API calls #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this commit is to simplify the rumPublicApi module by using the `recorderApi` directly, without buffering the calls. This is possible because the recorder api already has logic to support early calls to `start` and `stop`. The `getSessionReplayLink` implementation had to be slightly changed to work similarly to `start` and `stop`.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2563 +/- ##
==========================================
+ Coverage 92.85% 92.87% +0.02%
==========================================
Files 228 228
Lines 6744 6737 -7
Branches 1480 1480
==========================================
- Hits 6262 6257 -5
+ Misses 482 480 -2 ☔ View full report in Codecov by Sentry. |
|
/to-staging |
|
🚂 Branch Integration: this build is next, merge in < 7m Commit 9db8ed4f81 will soon be integrated into staging-02. This build is next! (estimated merge in less than 7m) you can cancel this operation by commenting your pull request with |
|
🚂 Branch Integration: This commit was successfully integrated Commit 9db8ed4f81 has been merged into staging-02 in merge commit 62b23a1f57. Check out the triggered pipeline on Gitlab 🦊 |
amortemousque
approved these changes
Jan 15, 2024
bcaudan
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goal of this commit is to simplify the rumPublicApi module by using the
recorderApidirectly, without buffering the calls.Changes
This is possible because the recorder api already has logic to support early calls to
startandstop. ThegetSessionReplayLinkimplementation had to be slightly changed to work similarly tostartandstop.Testing
I have gone over the contributing documentation.