Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️[RUM-3235] collect vital.name attribute #2609

Merged
merged 2 commits into from Feb 16, 2024
Merged

Conversation

bcaudan
Copy link
Collaborator

@bcaudan bcaudan commented Feb 15, 2024

Motivation

Collect vital.name attribute

Changes

  • bump schema
  • add vital.name attribute

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (84cd328) 92.83% compared to head (95f7dc6) 92.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2609      +/-   ##
==========================================
+ Coverage   92.83%   92.85%   +0.01%     
==========================================
  Files         237      237              
  Lines        6868     6868              
  Branches     1506     1506              
==========================================
+ Hits         6376     6377       +1     
+ Misses        492      491       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcaudan bcaudan changed the title ⚗️[RUM-2889] collect vital.name attribute ⚗️[RUM-3235] collect vital.name attribute Feb 15, 2024
@bcaudan
Copy link
Collaborator Author

bcaudan commented Feb 16, 2024

/to-staging

@dd-devflow
Copy link

dd-devflow bot commented Feb 16, 2024

🚂 Branch Integration: starting soon, merge in < 9m

Commit 95f7dc688c will soon be integrated into staging-07.

This build is going to start soon! (estimated merge in less than 9m)

Use /to-staging -c to cancel this operation!

@bcaudan bcaudan marked this pull request as ready for review February 16, 2024 13:35
@bcaudan bcaudan requested a review from a team as a code owner February 16, 2024 13:35
dd-mergequeue bot added a commit that referenced this pull request Feb 16, 2024
Co-authored-by: Bastien Caudan <bastien.caudan@datadoghq.com>
@dd-devflow
Copy link

dd-devflow bot commented Feb 16, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit 95f7dc688c has been merged into staging-07 in merge commit d09adb877d.

Check out the triggered pipeline on Gitlab 🦊

@bcaudan bcaudan merged commit 613ab37 into main Feb 16, 2024
18 checks passed
@bcaudan bcaudan deleted the bcaudan/vital-name branch February 16, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants