Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Resolve ws package to vulnerability-free version #2827

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

N-Boutaib
Copy link
Contributor

@N-Boutaib N-Boutaib commented Jun 24, 2024

Motivation

This PR addresses the following vulnerability https://github.com/DataDog/browser-sdk/security/dependabot/82

Changes

Upgrading packages and resolving those with old version to the new one

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@N-Boutaib N-Boutaib marked this pull request as ready for review June 24, 2024 12:34
@N-Boutaib N-Boutaib requested a review from a team as a code owner June 24, 2024 12:34
Copy link

cit-pr-commenter bot commented Jun 24, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 0 B 160.50 KiB 160.50 KiB N/A%
Logs 0 B 58.09 KiB 58.09 KiB N/A%
Rum Slim 0 B 109.02 KiB 109.02 KiB N/A%
Worker 0 B 25.21 KiB 25.21 KiB N/A%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext N/A 0.001 0.001
addaction N/A 0.031 0.031
adderror N/A 0.032 0.032
addtiming N/A 0.001 0.001
startview N/A 0.888 0.888
startstopsessionreplayrecording N/A 0.820 0.820
logmessage N/A 0.019 0.019
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext NaN KiB 20.63 KiB NaN KiB
addaction NaN KiB 69.42 KiB NaN KiB
adderror NaN KiB 87.57 KiB NaN KiB
addtiming NaN KiB 20.64 KiB NaN KiB
startview NaN KiB 320.19 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 15.42 KiB NaN KiB
logmessage NaN KiB 71.43 KiB NaN KiB

🔗 RealWorld

package.json Outdated Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.11%. Comparing base (52ee526) to head (508ba89).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2827      +/-   ##
==========================================
+ Coverage   93.10%   93.11%   +0.01%     
==========================================
  Files         246      246              
  Lines        7247     7247              
  Branches     1626     1626              
==========================================
+ Hits         6747     6748       +1     
+ Misses        500      499       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@N-Boutaib N-Boutaib merged commit 1792105 into main Jun 24, 2024
20 checks passed
@N-Boutaib N-Boutaib deleted the najib.boutaib/fix-security-vulnerability-inws-package branch June 24, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants