-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUMF-617] Extract XHR and Fetch proxies #468
Conversation
update the design to ease the testing not mandatory but I lost some time suspecting an issue with that...
c454de2
to
59061d3
Compare
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
+ Coverage 87.41% 87.50% +0.08%
==========================================
Files 32 34 +2
Lines 2034 2112 +78
Branches 411 416 +5
==========================================
+ Hits 1778 1848 +70
- Misses 256 264 +8
Continue to review full report at Codecov.
|
59061d3
to
76017bd
Compare
76017bd
to
c311c29
Compare
prevent batch from previous tests to keep running and send unwanted requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
Current proxies of XHR and fetch were managed by request collection which was handled as a singleton to avoid to proxy XHR and fetch multiple times.
With the future integration of tracing inside the sdk (cf #461), we would want to collect request with trace id for rum but not for logs.
In a npm setup this would be problematic since the request collection instance would be shared between rum and logs.
Changes
Testing
Automated tests
I have gone over the contributing documentation.