Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUMF-620]: Send service as tag and attribute #501

Closed
wants to merge 1 commit into from

Conversation

glorieux
Copy link
Contributor

Motivation

Using service as attribute only requires some UI and Facets changes.

Changes

Dual ship service as tag and attribute while we make the required changes.

Testing


I have gone over the contributing documentation.

@glorieux glorieux requested a review from a team as a code owner August 25, 2020 07:06
@codecov-commenter
Copy link

Codecov Report

Merging #501 into master will decrease coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage   87.98%   87.66%   -0.32%     
==========================================
  Files          35       35              
  Lines        2155     2156       +1     
  Branches      433      434       +1     
==========================================
- Hits         1896     1890       -6     
- Misses        259      266       +7     
Impacted Files Coverage Δ
packages/core/src/configuration.ts 83.72% <100.00%> (+0.38%) ⬆️
packages/rum/src/rum.ts 86.82% <0.00%> (-4.66%) ⬇️
packages/rum/src/performanceCollection.ts 61.66% <0.00%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de0cae4...bfd7d7b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants