Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tracer): provide keys and values #743

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix(tracer): provide keys and values #743

merged 1 commit into from
Jul 19, 2023

Conversation

luphaz
Copy link
Contributor

@luphaz luphaz commented Jul 19, 2023

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

  • This PR aims to fix error logs similar to this

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

@luphaz luphaz self-assigned this Jul 19, 2023
@luphaz luphaz marked this pull request as ready for review July 19, 2023 11:32
@luphaz luphaz requested a review from a team as a code owner July 19, 2023 11:32
@luphaz luphaz changed the title fix(tracer): provide key and values fix(tracer): provide keys and values Jul 19, 2023
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jul 19, 2023 •
edited
Loading

Datadog Report

Branch report: fix-ignored-key-without-a-value
Commit report: 3228bd0

✅ chaos-controller: 0 Failed, 0 New Flaky, 487 Passed, 0 Skipped, 6m 44.17s Wall Time

@luphaz luphaz merged commit f9ba591 into main Jul 19, 2023
18 checks passed
@luphaz luphaz deleted the fix-ignored-key-without-a-value branch July 19, 2023 13:04
ghost pushed a commit that referenced this pull request Jul 21, 2023
@luphaz @diyarab
fix(tracer): provide key and values (#743)
ea7f736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptnapoleon ptnapoleon ptnapoleon approved these changes

Assignees

@luphaz luphaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luphaz @ptnapoleon