Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chart to set deletionTimeout value actually read by config.go #799

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

ptnapoleon
Copy link
Contributor

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Oct 23, 2023

Datadog Report

Branch report: phil/refix-chart
Commit report: 69c9e88

chaos-controller: 0 Failed, 0 New Flaky, 666 Passed, 0 Skipped, 6m 46.65s Wall Time

@aymericDD
Copy link
Contributor

Thanks for the fix 🙏

@ptnapoleon ptnapoleon merged commit 99a8f91 into main Oct 24, 2023
18 checks passed
@ptnapoleon ptnapoleon deleted the phil/refix-chart branch October 24, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants