-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace tag the disruptions.gauge metric #847
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 720 Passed, 2 Skipped, 7m 13.45s Wall Time |
I've confirmed this works! the namespace tag for this metric now lists the number of disruptions in that namespace, no longer attributing them all to |
} | ||
|
||
// send metrics | ||
if err := r.MetricsSink.MetricStuckOnRemovalGauge(float64(stuckOnRemoval)); err != nil { | ||
r.BaseLog.Errorw("error sending stuck_on_removal_total metric", "error", err) | ||
} | ||
|
||
if err := r.MetricsSink.MetricDisruptionsGauge(float64(len(l.Items))); err != nil { | ||
r.BaseLog.Errorw("error sending disruptions.gauge metric", "error", err) | ||
if len(namespaces) > 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and this works in the case of 0 disruptions, disruptions in 1 namespace, and disruptions in many namespaces
Co-authored-by: zhiyanfoo <zhiyanfoo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What does this PR do?
Please briefly describe your changes as well as the motivation behind them:
disruptions.gauge
at all. I've added a namespace tagCode Quality Checklist
Testing
unit
tests orend-to-end
tests.unit
tests orend-to-end
tests.x