Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAOSPLT-316: Implement authentication in the http eventnotifier #865

Merged
merged 21 commits into from
May 28, 2024

Conversation

diyarab
Copy link
Contributor

@diyarab diyarab commented May 8, 2024

What does this PR do?

  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

  • This PR implements authentication in the http eventnotifier.

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

aymericDD and others added 4 commits April 26, 2024 15:43
Serialize the disruption and it into the payload of the http request sent by the HTTP notifier component.
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 8, 2024

Datadog Report

Branch report: diyara.bissembayeva/CHAOSPLT-316/http-add-auth
Commit report: e6b6240
Test service: chaos-controller

✅ 0 Failed, 738 Passed, 2 Skipped, 7m 14.46s Total Time

@diyarab diyarab changed the title Diyara.bissembayeva/chaosplt 316/http add auth Implement authentication in the http eventnotifier May 10, 2024
@diyarab diyarab changed the title Implement authentication in the http eventnotifier CHAOSPLT-316: Implement authentication in the http eventnotifier May 10, 2024
@diyarab diyarab force-pushed the diyara.bissembayeva/CHAOSPLT-316/http-add-auth branch from b9b3a26 to 7dfa0d4 Compare May 21, 2024 12:47
@diyarab diyarab marked this pull request as ready for review May 21, 2024 12:50
@diyarab diyarab requested a review from a team as a code owner May 21, 2024 12:50
@diyarab diyarab requested a review from ptnapoleon May 21, 2024 13:22
ptnapoleon
ptnapoleon previously approved these changes May 22, 2024
@ptnapoleon ptnapoleon requested a review from clairecng May 22, 2024 13:58
ptnapoleon
ptnapoleon previously approved these changes May 22, 2024
Copy link
Contributor

@ptnapoleon ptnapoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but I would like a second reviewer (i nominated Claire but it can be anyone)

taihuynh167
taihuynh167 previously approved these changes May 22, 2024
Copy link
Contributor

@taihuynh167 taihuynh167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some minor comments

eventnotifier/http/http.go Show resolved Hide resolved
eventnotifier/http/http.go Outdated Show resolved Hide resolved
eventnotifier/types/types.go Outdated Show resolved Hide resolved
@diyarab diyarab dismissed stale reviews from taihuynh167 and ptnapoleon via 19a76e7 May 23, 2024 17:59
@diyarab diyarab requested a review from taihuynh167 May 23, 2024 21:29
Copy link
Contributor

@clairecng clairecng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add documentation on what this feature do here. (We should also definitely indicate that this feature ONLY support Authentication through a bearer token with a Authorization header!)

You could also add more comments in general I think.

Otherwise, 👍 nice one! I'll approve once the changes for documentation are made 👍

chart/values.yaml Outdated Show resolved Hide resolved
eventnotifier/http/auth.go Show resolved Hide resolved
clairecng
clairecng previously approved these changes May 28, 2024
@datadog-datadog-prod-us1
Copy link

Software Composition Analysis

We found vulnerabilities in the following libraries (compared e6b6240 against b3f82b8):

@diyarab diyarab merged commit 24b907e into main May 28, 2024
18 checks passed
@diyarab diyarab deleted the diyara.bissembayeva/CHAOSPLT-316/http-add-auth branch May 28, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants