#401 - Allow configuration of Traces settings in datadog.conf #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master from DataDog
Merge from Datadog Master
talwai
reviewed
Mar 3, 2017
attributes/default.rb
Outdated
| default['datadog']['enable_trace_agent'] = false | ||
| default['datadog']['extra_sample_rate'] = 1 | ||
| default['datadog']['max_traces_per_second'] = 10 | ||
| default['datadog']['receiver_port'] = 7777 |
There was a problem hiding this comment.
we're actually deprecating 7777 for 8126 to be contiguous with statsd (though both work for the time being) . mind updating the default?
|
LGTM, aside from the comment - would be nice if @olivielpeau could take a glance as well |
olivielpeau
reviewed
Mar 7, 2017
There was a problem hiding this comment.
@mlcooper: thanks! I've added a small comment on the attribute name, otherwise LGTM
attributes/default.rb
Outdated
| default['datadog']['connection_limit'] = 2000 | ||
|
|
||
| # ddtrace python version | ||
| default['datadog']['ddtrace_python_ver'] = nil |
There was a problem hiding this comment.
could you use a full ddtrace_python_version attribute name here? (just trying to be consistent with all the other occurences of *_version in the attributes names of the cookbook)
same thing for ddtrace_gem_version below
dsalvador-dsalvador
pushed a commit
to dsalvador-dsalvador/chef-datadog
that referenced
this pull request
Mar 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.