Set windows values for agent 6 #525
Conversation
permission config file on windows install checks yaml in sub dir of conf.d on agent 6 Signed-off-by: Richard Lavey <richard.lavey@calastone.com>
Signed-off-by: Richard Lavey <richard.lavey@calastone.com>
There was a problem hiding this comment.
Thanks @rlaveycal for updating this!
Looks good to me overall, I've made a comment on the change to the sub-dir of conf.d on Agent 6, which would slightly break things for existing Linux users, coul you have a look?
providers/monitor.rb
Outdated
|
|
||
| def yaml_dir | ||
| if node['datadog']['agent6'] | ||
| ::File.join(node['datadog']['agent6_config_dir'], 'conf.d', "#{new_resource.name}.d") |
There was a problem hiding this comment.
could you remove the "#{new_resource.name}.d" part to keep only ::File.join(node['datadog']['agent6_config_dir'], 'conf.d')? Agent 6 still supports that configuration scheme (and that's the scheme the cookbook currently uses for Linux Agent 6). Changing the scheme now would slightly break the cookbook for Linux Agent 6 users upgrading from previous versions of the cookbook.
I'm planning to switch to the new scheme in the next major version of the cookbook.
Signed-off-by: Richard Lavey <richard.lavey@calastone.com>
Closes #524