Add -1 version suffix if not set on OSes with yum #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
force-pushed
the
albertvaka/rhel-auto-version
branch
2 times, most recently
from
26507e0
to
3741246
Compare
albertvaka
force-pushed
the
albertvaka/rhel-auto-version
branch
from
3741246
to
048b849
Compare
KSerrania
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
-1suffix to agent versions before passing them toyum_package. Otherwise, it fails to find them.Tested on RHEL and CentOS. Assuming it works the same way on Fedora and Amazon Linux since they also use
yum.RHEL >= 8 and Fedora >= 28 use
dnfinstead of `yum, which takes both formats so it should still be fine to add the suffix.