Add installation info metadata support #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbogtob
force-pushed
the
kbogtob/add-install-info
branch
from
bbda01f
to
a865ced
Compare
albertvaka
reviewed
Apr 22, 2020
recipes/install_info.rb
Outdated
|
|
||
| variables( | ||
| install_method: "chef-#{Chef::VERSION}", | ||
| install_method_version: "datadog-cookbook-#{Chef::Datadog.cookbook_version(run_context)}" |
There was a problem hiding this comment.
Maybe we want to call it datadog_cookbook so the dash - separates name from version.
| @@ -0,0 +1,6 @@ | |||
| <%= JSON.parse(({ | |||
There was a problem hiding this comment.
JSON.parse().to_json.to_yaml is this the way to print a yaml? 🤔
There was a problem hiding this comment.
C/p from other template, I'll improve
kbogtob
force-pushed
the
kbogtob/add-install-info
branch
from
436c1cf
to
f0e2a03
Compare
albertvaka
approved these changes
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds the installation info metadata to the chef cookbook so the agent returns that it was installed by the triple chef/chef version/cookbook version
Motivation.
Allow customers to track their chef installation. Allows us to make stats on installation methods.