[dd-agent] Add attribute to allow agent downgrade #359
Conversation
|
Despite the Foodcritic warning, it works. If you don't find a way to fix it, I'm fine with silencing this error in this specific case. Tested on Ubuntu 15.04 and Centos 7.0. 👍 |
olivielpeau
force-pushed
the
olivielpeau/allow-agent-downgrade
branch
3 times, most recently
from
3e2d26d
to
544e665
Compare
|
@degemer The Foodcritic warning kind of makes sense, so I separated the Also added spec tests on the new attribute |
| version dd_agent_version | ||
| action node['datadog']['agent_package_action'] # default is :install | ||
| allow_downgrade node['datadog']['agent_allow_downgrade'] | ||
| end |
There was a problem hiding this comment.
If we want to be really cautious, we could add a default with the old resource.
List of all the Linux platform_family: https://github.com/chef/ohai/blob/af061dd99e771197b9aaec8c63a42b07a72662f2/lib/ohai/plugins/linux/platform.rb
I don't see anything missing, but...
There was a problem hiding this comment.
Discussed this offline: since we're doing the same test in recipes/repository.rb, the cookbook doesn't work on other platforms anyway, so no need to fall back on a default here.
| @@ -298,6 +306,98 @@ def set_env_var(name, value) | |||
| end | |||
| end | |||
|
|
|||
| context 'package downgrade' do | |||
Still not allowed by default. Switching the attribute to `true` allows downgrades: * Straightforward for rhel/fedora: the yum and rpm package providers support a parameter that does just that * Uses `--force-yes` on debian: there's no direct option on the apt provider. `apt-get` supports a more fine-grained option (`--allow-downgrades`) since version `1.1` of `apt`, but it ships with ubuntu starting from `16.04` only, so we stick to using `--force-yes`.
`allow_downgrade` is available on `yum_package` but not on the generic `package` resource, so it makes sense to designate the provider explicitely. Also: * update the spec tests to adapt to this change * test that the `datadog-agent-base` package is removed
olivielpeau
force-pushed
the
olivielpeau/allow-agent-downgrade
branch
from
544e665
to
f04306f
Compare
|
CI is 💚 , merging, thanks @degemer! |
Still not allowed by default. Switching the attribute to
trueallows downgrades:support a parameter that does just that
--force-yeson debian because:provider
apt-getsupports a more fine-grained option(
--allow-downgrades) since version1.1ofapt, but it ships withubuntu starting from
16.04only, so we stick to using--force-yes. It could be nice to switch the option depending on the version ofapt, but it'd add some complexity to the logic.Notes on downgrading packages with
aptWith
apt, downgrading can be dangerous for packages that have dependencies/on which other packages depend. Fromdpkg's manpage, on downgrades:This shouldn't be the case of the
datadog-agentpackage so downgrading should be relatively safe.Also, using
--force-yesis equivalent to allowingremove-essential,downgradesandchange-held-packages. None of these should be dangerous when applied to thedatadog-agentpackage only. For reference see the manpage ofapt1.2: http://manpages.ubuntu.com/manpages/xenial/en/man8/apt-get.8.html