Fix oneOf generation with mixed types including primitives #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarimo
approved these changes
Mar 8, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Mar 8, 2023
* Fix early exit of oneOf generation with mixed types * pre-commit fixes * remove primitive check in case future oneOfs have other edge cases --------- Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> 3a701d6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the missing model in the generated python of https://github.com/DataDog/datadog-api-spec/pull/2093
This change allows there to be mixed types in oneOfs where some of the types are primitives. Previously, if there was a primitive type in the oneOf, the generation would skip the entire oneOf generation.