Fix Python type checking #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![api-clients-generation-pipeline[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
This was skipped for unknown reasons.
api-clients-generation-pipeline
bot
requested a review
from a team
as a code owner
github-actions
bot
added
the
documentation
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/1039
branch
from
55ed92d
to
cadfc6d
Compare
api-clients-generation-pipeline
bot
changed the title
therve
force-pushed
the
datadog-api-spec/generated/1039
branch
from
bb333fd
to
e9939d8
Compare
api-clients-generation-pipeline
bot
force-pushed
the
datadog-api-spec/generated/1039
branch
from
e9939d8
to
e5e7b5b
Compare
zippolyte
reviewed
Jun 17, 2021
Comment on lines
-1371
to
-1373
| # Buld a configuration that doesn't discard unknown keys for primitive types | ||
| discard_configuration = copy.deepcopy(constant_kwargs["_configuration"]) | ||
| discard_configuration.discard_unknown_keys = False |
There was a problem hiding this comment.
this is removed on purpose ?
There was a problem hiding this comment.
Yep, the must_convert change covers that area now.
therve
approved these changes
Jun 17, 2021
api-clients-generation-pipeline
bot
deleted the
datadog-api-spec/generated/1039
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jun 17, 2021
* Enforce type checking This was skipped for unknown reasons. * Regenerate client from commit 7f25c3e of spec repo Co-authored-by: Thomas Hervé <thomas.herve@datadoghq.com> Co-authored-by: api-clients-generation-pipeline[bot] <54105614+api-clients-generation-pipeline[bot]@users.noreply.github.com> Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com> b835fc3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See DataDog/datadog-api-spec#1039
Closes #291