Implement Jinja Code Generation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor default configuration to grab env vars where appropriate
therve
reviewed
Oct 4, 2023
therve
reviewed
Oct 4, 2023
therve
reviewed
Oct 4, 2023
therve
reviewed
Oct 4, 2023
| pub async fn CreateFastlyService( | ||
| configuration: &configuration::Configuration, | ||
| params: CreateFastlyServiceParams, | ||
| ) -> Result<ResponseContent<crate::datadogV2::FastlyServiceResponse>, Error<CreateFastlyServiceError>> |
There was a problem hiding this comment.
We need to think about having an interface that only returns FastlyServiceResponse. Maybe we can use the with_http_info pattern that is present in Java and Python for example.
There was a problem hiding this comment.
good idea, the normal create_fastly_service function can be a small wrapper around create_fastly_service_with_http_info for example. Will test it out
|
Looks really good. We should solve some high level interface issues before bringing in more APIs, but this is a great start. It would also be nice to have slightly more directory structure. I'm thinking at least separate apis and models. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uses the go generator code, modified to output Rust