[test] Use Node 16 in unit tests #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drarig29
commented
Jul 24, 2023
| @@ -33,8 +34,11 @@ const runMockedTask = (mockName: string): MockTestRunner => { | |||
| throw Error(`The mocked task file does not exist: mocks/${mockName}.js\n` + 'Did you forget to run `yarn build`?') | |||
| } | |||
|
|
|||
| // See `16.15.0` in `.node-version` | |||
There was a problem hiding this comment.
I added this comment to be able to easily grep for 16.15.0 and get all the places where the node version is used.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we target Node 16, we are still using Node 10 in the unit tests.
This now makes the CI fail because of the
?.operator being used in JS. (see failing CI job)For the record, this operator was introduced when bumping
proxy-agentin datadog-ci in DataDog/datadog-ci#957. This package targets Node 14.This PR bumps
azure-pipelines-task-libto version 4 (which supports Node 16 - see microsoft/azure-pipelines-task-lib#844) and passes16as a parameter ofMockTestRunner.run().