[CIVIS-7722] Parametrized tests support for cucumber #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmarchenko
changed the title
anmarchenko
force-pushed
the
anmarchenko/parametrized_cucumber_tests
branch
from
3338929
to
46ce917
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 99.19% 99.15% -0.05%
==========================================
Files 147 147
Lines 6242 6284 +42
Branches 256 264 +8
==========================================
+ Hits 6192 6231 +39
- Misses 50 53 +3 ☔ View full report in Codecov by Sentry. |
| expect(span.get_tag(Datadog::CI::Ext::Test::TAG_NAME)).to eq("scenario with examples") | ||
|
|
||
| expect(span.get_tag(Datadog::CI::Ext::Test::TAG_PARAMETERS)).to eq( | ||
| "{\"num1\":\"#{index}\",\"num2\":\"#{index + 1}\",\"total\":\"#{index + index + 1}\"}" |
There was a problem hiding this comment.
does the UI render these parameters correctly? The format the other tracers follow is
{
"arguments": // ... your parameters
"metadata": { // ... extra metadata }
}
There was a problem hiding this comment.
Working on it, UI is handling it correctly:
There was a problem hiding this comment.
@juan-fernandez fixed:
juan-fernandez
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds parametrized test support for cucumber-rby (version 4 and above):
Motivation
Currently all test runs with scenario outline have the same test fingerprint and treated as a single test being run multiple times. We should use
test.parameterstag to distinguish these tests from each otherAdditional Notes
How to test the change?
Tested using https://github.com/anmarchenko/jekyll