[CIVIS-3172] use repository name as default test service name #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 99.15% 99.11% -0.05%
==========================================
Files 147 147
Lines 6289 6338 +49
Branches 264 269 +5
==========================================
+ Hits 6236 6282 +46
- Misses 53 56 +3 ☔ View full report in Codecov by Sentry. |
anmarchenko
force-pushed
the
anmarchenko/use_repository_name_as_default_service_name
branch
from
c1de6d6
to
357ca28
Compare
anmarchenko
force-pushed
the
anmarchenko/use_repository_name_as_default_service_name
branch
from
357ca28
to
0f28e32
Compare
romainkomorndatadog
approved these changes
Jan 16, 2024
| @@ -21,7 +22,9 @@ class Settings < Datadog::CI::Contrib::Settings | |||
|
|
|||
| option :service_name do |o| | |||
| o.type :string | |||
| o.default { Datadog.configuration.service_without_fallback || Ext::DEFAULT_SERVICE_NAME } | |||
| o.default do | |||
| Datadog.configuration.service_without_fallback || Utils::Git.repository_name || Ext::DEFAULT_SERVICE_NAME | |||
There was a problem hiding this comment.
Should this come from a function provided by our CI gem's utils, instead of a per-framework "implementation"?
eg: Utils::Something.get_service_name()?
There was a problem hiding this comment.
yes, I agree, the logic to look into Datadog.configuration and Utils::Git should be extracted, will do it
anmarchenko
changed the title
romainkomorndatadog
approved these changes
Jan 16, 2024
anmarchenko
deleted the
anmarchenko/use_repository_name_as_default_service_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In order to simplify onboarding for new customers it provides better default service name when none is provided.
Additional Notes
How to test the change?
Unit tests are provided.
Example project without service name configured:
https://github.com/anmarchenko/sidekiq/tree/anmarchenko/datadog-ci-visibility
Service is set to repository name:
