Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-8548] make test suite names more readable #105

Merged
merged 4 commits into from
Jan 16, 2024

Conversation

anmarchenko
Copy link
Contributor

@anmarchenko anmarchenko commented Jan 16, 2024

What does this PR do?
Changes test suite name and test name definitions to improve UX and make test dashboard look nicer.

Cucumber

  • uses feature name as a prefix for test suite name

Before:
image

After:
image

RSpec

  • uses top-level example group description as test suite name
  • removes top-level example group description from test name to avoid repetition

Before:
image

After:
image

Minitest

  • remove test suite class name from test.name tag to avoid unnecessary repetition

Before:
image

After:
image

Motivation
Current test suite names and test names are not easily readable in test runs table

How to test the change?
Tested using a number of open source projects (see screenshots above)

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c56656c) 99.15% compared to head (055cac5) 99.14%.
Report is 11 commits behind head on main.

Files Patch % Lines
lib/datadog/ci/contrib/cucumber/formatter.rb 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   99.15%   99.14%   -0.02%     
==========================================
  Files         147      147              
  Lines        6289     6307      +18     
  Branches      264      272       +8     
==========================================
+ Hits         6236     6253      +17     
- Misses         53       54       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko force-pushed the anmarchenko/readable_test_suite_names branch from 055cac5 to 00d39f0 Compare January 16, 2024 15:50
@anmarchenko anmarchenko marked this pull request as ready for review January 16, 2024 15:57
@anmarchenko anmarchenko requested review from a team as code owners January 16, 2024 15:57
@anmarchenko anmarchenko merged commit 8dd092a into main Jan 16, 2024
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/readable_test_suite_names branch January 16, 2024 16:26
@github-actions github-actions bot added this to the 0.7.0 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants