Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-8552] ci-queue support for rspec #112

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

anmarchenko
Copy link
Contributor

@anmarchenko anmarchenko commented Jan 23, 2024

What does this PR do?
Fix #96

Adds RSpec instrumentation support when running with ci-queue test runner. It instruments RSpec::Queue::Runner that is used by ci-queue and also creates "single-test" test suite akin to Minitest parallel tests if we detect to be running in a RSpec::Core::Example instrumented by ci-queue. Also it fixes our handling of pending tests correctly marking them as skipped and adds a lot of unit tests around all of the ways we can skip tests in RSpec

Motivation
We have users of this library who run their rspec test suites using ci-queue

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c3ccfee) 99.06% compared to head (1d7d3ac) 98.96%.

Files Patch % Lines
...c/datadog/ci/contrib/rspec/instrumentation_spec.rb 93.20% 7 Missing ⚠️
lib/datadog/ci/contrib/rspec/example.rb 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   99.06%   98.96%   -0.11%     
==========================================
  Files         149      151       +2     
  Lines        6308     6469     +161     
  Branches      288      299      +11     
==========================================
+ Hits         6249     6402     +153     
- Misses         59       67       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko marked this pull request as ready for review January 23, 2024 13:13
@anmarchenko anmarchenko requested review from a team as code owners January 23, 2024 13:13
@anmarchenko anmarchenko merged commit d1034f0 into main Jan 23, 2024
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/rspec_instrumentation_ci_queue branch January 23, 2024 13:55
@github-actions github-actions bot added this to the 0.7.0 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track retries of specs
3 participants