Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support validation errors for CI spans #78

Merged
merged 2 commits into from Dec 6, 2023

Conversation

anmarchenko
Copy link
Contributor

@anmarchenko anmarchenko commented Dec 5, 2023

Motivation
Currently we don't see any feedback when invalid events are being discarded during serialization phase. This behaviour was inherited from ddtrace-rb where such errors are only emitted in debug mode.

For CI visibility library it is very important to report all the spans, so skipping invalid spans is a serious error that requires an action.

What does this PR do?

  • Elevates logging level for invalid spans skipping to WARN
  • Now event serializer stores validation errors so that they could be logged for easier debugging

How to test the change?
Unit tests are provided

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c42591d) 99.34% compared to head (b5938c5) 99.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files         131      131           
  Lines        4754     4762    +8     
  Branches      166      166           
=======================================
+ Hits         4723     4731    +8     
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anmarchenko anmarchenko requested review from a team and juan-fernandez December 5, 2023 13:11
@anmarchenko anmarchenko marked this pull request as ready for review December 5, 2023 13:11
@anmarchenko anmarchenko force-pushed the anmarchenko/validation_errors_for_spans branch from 7d2ef94 to af7fc86 Compare December 6, 2023 10:27
@anmarchenko anmarchenko merged commit 429bbfc into main Dec 6, 2023
26 checks passed
@anmarchenko anmarchenko deleted the anmarchenko/validation_errors_for_spans branch December 6, 2023 10:30
@github-actions github-actions bot added this to the 0.5.0 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants