Fix telemetry using the global namespace #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
reviewed
Jul 5, 2021
There was a problem hiding this comment.
Left a few comments, but overall LGTM.
If I understand correctly (could you update the PR description if this looks correct):
- before this PR: the metric namespace (and global tags) would still be added to telemetry metrics when telemetry is not configured with its own endpoint.
- after this PR: the metric namespace (and global tags) are not added to telemetry metrics in all cases, which is the correct behavior.
hush-hush
force-pushed
the
maxime/fix-telemetry-namespace
branch
2 times, most recently
from
87b3adf
to
0ed86ff
Compare
The telemetry metrics should not use the user namespace. This commit also include a rework in the tests that allows us to test the telemety from start to finish (end-to-end)
hush-hush
force-pushed
the
maxime/fix-telemetry-namespace
branch
from
0ed86ff
to
62e81f9
Compare
olivielpeau
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The telemetry metrics should not use the user namespace.
Before this PR: the metric namespace would still be added to telemetry metrics when telemetry is not configured with its own endpoint.
This commit also include a rework in the tests that allows us to test the telemetry from start to finish (end-to-end)