Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IsClosed method statsd client #254

Merged

Conversation

lucassscaravelli
Copy link
Contributor

fix issues #140

@hush-hush
Copy link
Member

Thanks a lot for the PR @lucassscaravelli !

I added a few comments, but overall I think we will be able to merge.

statsd/statsd.go Outdated Show resolved Hide resolved
statsd/statsd_test.go Outdated Show resolved Hide resolved
statsd/statsd_test.go Outdated Show resolved Hide resolved
statsd/statsd.go Outdated Show resolved Hide resolved
statsd/statsd.go Outdated Show resolved Hide resolved
statsd/statsd.go Outdated Show resolved Hide resolved
@lucassscaravelli
Copy link
Contributor Author

@hush-hush thanks for review! Fixed 👍

Copy link
Member

@hush-hush hush-hush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change

statsd/statsd.go Show resolved Hide resolved
@hush-hush hush-hush merged commit a3ba2cc into DataDog:master Mar 1, 2022
@lucassscaravelli lucassscaravelli deleted the feature/statsd-is-closed-method branch March 25, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants