Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure tracer initialization does not override DD_TAGS #563

Merged

Conversation

wconti27
Copy link
Contributor

@wconti27 wconti27 commented Aug 1, 2024

What does this PR do?

Prevents DD_TAGS from being overwritten.

Motivation

Customer escalation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@wconti27 wconti27 requested a review from a team as a code owner August 1, 2024 16:57
},
});
// add lambda tags to DD_TAGS environment variable
const ddtags = updateDDTags({"_dd.origin": "lambda"})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name might differ with the current existing function used in metrics, but might be a good think to refactor in the future

@duncanista duncanista merged commit 8429c32 into DataDog:main Aug 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants