Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type check Lambda events when extracting trigger tags #136

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

DylanLovesCoffee
Copy link
Contributor

What does this PR do?

Short circuits trigger tag extraction if the event is not a dictionary. An event can be any type so we should not throw an exception.

Motivation

Raised by a customer.

Testing Guidelines

Built and tested locally. Added a unit test for good measure.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DylanLovesCoffee DylanLovesCoffee requested a review from a team as a code owner April 26, 2021 17:37
@DylanLovesCoffee DylanLovesCoffee merged commit 87120e9 into main Apr 26, 2021
@DylanLovesCoffee DylanLovesCoffee deleted the dylan/event-type-exception branch April 26, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants