Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign layer using AWS Signer before publishing #41

Merged
merged 4 commits into from
Dec 3, 2020
Merged

Conversation

nhinsch
Copy link
Contributor

@nhinsch nhinsch commented Dec 3, 2020

What does this PR do?

  • Add a sign_layers script which uploads built layers to S3, uses AWS Signer to sign them, and then downloads the signed layers back to the developer's machine, replacing the unsigned layers.
  • Replace the publish_staging script with publish_sandbox, and publish to the sa-east-1 region to reflect our current practices.
  • Update the publish_sandbox and publish_prod scripts to call sign_layers before publish_layers.

Bonus:

  • Swap out the actions/setup-ruby GitHub action in favor of ruby/setup-ruby. The old action was flaking and apparently it's on it's way to being deprecated.

Motivation

We want to support the new Code Signing for Lambda feature. This will allow customers to use the layer with functions that are configured to require signed code.

Testing Guidelines

Tested in the sandbox account.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@nhinsch nhinsch requested a review from a team as a code owner December 3, 2020 18:46
Copy link
Contributor

@DarcyRaynerDD DarcyRaynerDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhinsch nhinsch merged commit f95fd89 into master Dec 3, 2020
@nhinsch nhinsch deleted the ngh/sign-layers branch December 3, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants