Set DATADOG_HOST according to DD_SITE or DD_DD_URL when MetricsProvider is enabled. Resolves #103 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er is enabled. Resolves DataDog#103
Codecov Report
@@ Coverage Diff @@
## master #104 +/- ##
==========================================
+ Coverage 57.19% 57.29% +0.10%
==========================================
Files 31 31
Lines 4175 4185 +10
==========================================
+ Hits 2388 2398 +10
Misses 1606 1606
Partials 181 181
Continue to review full report at Codecov.
|
Co-authored-by: Cedric Lamoriniere <cedric.lamoriniere@datadoghq.com>
|
@clamoriniere Thanks! Addressed your requested change! |
clamoriniere
approved these changes
May 30, 2020
gtseres
pushed a commit
to gtseres/datadog-operator
that referenced
this pull request
Jun 1, 2020
…er is enabled. Resolves DataDog#103 (DataDog#104) * Set DATADOG_HOST according to DD_SITE or DD_DD_URL when MetricsProvider is enabled. Resolves DataDog#103 Co-authored-by: Cedric Lamoriniere <cedric.lamoriniere@datadoghq.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR creates a
DATADOG_HOSTenvironment variable that is defined whenmetricsProviderEnabled = true, as the client used to fetch the metrics from Datadog doesn't recognize eitherDD_SITEorDD_DD_URL.It:
DatadogHostthat corresponds to theDATADOG_HOSTenvironment variable namegetDatadogHostmethod topkg/controller/datadogagent/clusteragent.goDATADOG_HOSTenvironment variable whenmetricsProviderEnabledis trueMotivation
Addressing issue #103
Additional Notes