Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil pointer when DS Agent disabled #110

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

ahmed-mez
Copy link
Contributor

What does this PR do?

Do not panic when node agent isn't enabled

Motivation

Panics are bad

@ahmed-mez ahmed-mez added the bug Something isn't working label Jun 5, 2020
@ahmed-mez ahmed-mez requested a review from a team as a code owner June 5, 2020 14:28
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #110 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   57.44%   57.44%           
=======================================
  Files          31       31           
  Lines        4199     4199           
=======================================
  Hits         2412     2412           
  Misses       1606     1606           
  Partials      181      181           
Flag Coverage Δ
#unittests 57.44% <100.00%> (ø)
Impacted Files Coverage Δ
pkg/controller/datadogagent/systemprobe.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d07ed...a0a56a7. Read the comment docs.

@ahmed-mez ahmed-mez merged commit 16d4903 into master Jun 5, 2020
@ahmed-mez ahmed-mez deleted the ahmed-mez/fix-panic-agent branch June 5, 2020 14:42
@clamoriniere clamoriniere added this to the v0.3 milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants