Add DatadogMetric support in operator #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vboulineau
force-pushed
the
vboulineau/ddm_operator
branch
from
93cbf6b
to
eff0489
Compare
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 57.44% 57.25% -0.19%
==========================================
Files 31 31
Lines 4199 4216 +17
==========================================
+ Hits 2412 2414 +2
- Misses 1606 1620 +14
- Partials 181 182 +1
Continue to review full report at Codecov.
|
clamoriniere
approved these changes
Jun 23, 2020
ahmed-mez
reviewed
Jun 23, 2020
There was a problem hiding this comment.
Please update all the example files where we use metricsProviderEnabled
https://github.com/DataDog/datadog-operator/tree/master/examples
vboulineau
force-pushed
the
vboulineau/ddm_operator
branch
from
eff0489
to
7e5cb46
Compare
ahmed-mez
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add DatadogMetric support.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?