Add md5 hash config annotation to helm check #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
fanny-jiang
commented
Mar 7, 2024
| } | ||
|
|
||
| f.configAnnotationValue = hash | ||
| f.configAnnotationKey = fmt.Sprintf("checksum/%s-config", feature.HelmCheckIDType) |
There was a problem hiding this comment.
Should we add a new const for the helm check config annotation key? There's the MD5ChecksumAnnotationKey = "checksum/%s-custom-config" const, but it's more for custom configs
There was a problem hiding this comment.
That const is used for CC feature already and don't see problem using it here
datadog-operator/controllers/datadogagent/feature/clusterchecks/feature.go
Lines 267 to 268 in 36c4c4a
levan-m
approved these changes
Mar 8, 2024
fanny-jiang
added a commit
that referenced
this pull request
Mar 11, 2024
* Add md5 hash for config changes * Apply review suggestions (cherry picked from commit e0fa00d)
2 tasks
fanny-jiang
added a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add md5 hash annotation to helm check configMap and cluster agent pod template spec for helm check config changes.
Motivation
QA #1060
Helm check config changes were not being taken into account by the cluster agent/CCR and the cluster agent and CCR pods were not restarting after config changes.
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
QA steps for #1060 +
datadog-helm-check-configconfigmap should have the annotationchecksum/helm_check-custom-config: <md5_hash>helmCheck.enabled: e.ghelmCheck.collectEvents: truetohelmCheck.collectEvents: falseorhelmCheck.valuesAsTags: {"image.tag": "image_tag", "image.repository": "image_repo"}tohelmCheck.valuesAsTags: {"image.tag": "image_tag"}Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel