Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable provenance in gitlab #1133

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Disable provenance in gitlab #1133

merged 1 commit into from
Apr 26, 2024

Conversation

khewonc
Copy link
Contributor

@khewonc khewonc commented Apr 3, 2024

What does this PR do?

Previous:

$ docker manifest inspect xxx
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.oci.image.index.v1+json",
   "manifests": [
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 1810,
         "digest": "sha256:xxx",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.oci.image.manifest.v1+json",
         "size": 566,
         "digest": "sha256:xxx",
         "platform": {
            "architecture": "unknown",
            "os": "unknown"
         }
      }
   ]
}

Now:

$ docker manifest inspect xxx
{
	"schemaVersion": 2,
	"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
	"config": {
		"mediaType": "application/vnd.docker.container.image.v1+json",
		"digest": "sha256:xxx",
		"size": 8927
	},
	"layers": [
		{
			"mediaType": "application/vnd.docker.image.rootfs.diff.tar.gzip",
			"digest": "sha256:xxx",
			"size": 35983791
		},
		[...]
	]
}

Motivation

Release issues with unknown platform:

      "platform": {
        "architecture": "unknown",
        "os": "unknown"
      }

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@khewonc khewonc merged commit 29510eb into main Apr 26, 2024
23 checks passed
@khewonc khewonc deleted the khewonc/buildx-provenance branch April 26, 2024 21:55
celenechang pushed a commit that referenced this pull request May 3, 2024
celenechang added a commit that referenced this pull request May 3, 2024
Co-authored-by: khewonc <39867936+khewonc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants