Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RBACs for storageclass and limitrange collection (#1159) #1161

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

fanny-jiang
Copy link
Contributor

@fanny-jiang fanny-jiang commented Apr 30, 2024

What does this PR do?

Cherry-pick #1159

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

@fanny-jiang fanny-jiang added enhancement New feature or request qa/skip-qa labels Apr 30, 2024
@fanny-jiang fanny-jiang requested review from a team as code owners April 30, 2024 20:21
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.56%. Comparing base (f113d7a) to head (4166881).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             v1.6    #1161      +/-   ##
==========================================
+ Coverage   59.54%   59.56%   +0.01%     
==========================================
  Files         174      174              
  Lines       21510    21519       +9     
==========================================
+ Hits        12809    12818       +9     
  Misses       7930     7930              
  Partials      771      771              
Flag Coverage Δ
unittests 59.56% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/datadogagent/orchestrator.go 84.00% <100.00%> (+0.75%) ⬆️
controllers/datadogagent_controller.go 70.90% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f113d7a...4166881. Read the comment docs.

@fanny-jiang fanny-jiang merged commit abcb587 into v1.6 Apr 30, 2024
20 checks passed
@fanny-jiang fanny-jiang deleted the fanny/cherry-pick-1159 branch April 30, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants