Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] fix(controller): always try to update status (#1154) #1163

Merged
merged 1 commit into from
May 1, 2024

Conversation

celenechang
Copy link
Contributor

  • fix(controller): always try to update status

  • improve check-operator resiliency

  • improve how the status conditions are updated

  • Apply suggestions from code review

  • Update upgrade.go

  • nit


What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

* fix(controller): always try to update status

* improve check-operator resiliency

* improve how the status conditions are updated

* Apply suggestions from code review

Co-authored-by: Celene <celene@datadoghq.com>

* Update upgrade.go

* nit

---------

Co-authored-by: Celene <celene@datadoghq.com>
@celenechang celenechang added bug Something isn't working component/controller labels May 1, 2024
@celenechang celenechang added this to the v1.6.0 milestone May 1, 2024
@celenechang celenechang requested review from a team as code owners May 1, 2024 12:15
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

Attention: Patch coverage is 36.84211% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 59.56%. Comparing base (6f06176) to head (542abe8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             v1.6    #1163      +/-   ##
==========================================
- Coverage   59.56%   59.56%   -0.01%     
==========================================
  Files         174      174              
  Lines       21519    21565      +46     
==========================================
+ Hits        12818    12845      +27     
- Misses       7930     7941      +11     
- Partials      771      779       +8     
Flag Coverage Δ
unittests 59.56% <36.84%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
apis/datadoghq/v2alpha1/condition.go 5.15% <100.00%> (+5.15%) ⬆️
...ntrollers/datadogagent/controller_reconcile_ccr.go 47.43% <100.00%> (+2.84%) ⬆️
...rollers/datadogagent/controller_reconcile_agent.go 50.14% <0.00%> (-0.57%) ⬇️
...ntrollers/datadogagent/controller_reconcile_dca.go 26.37% <14.28%> (-1.84%) ⬇️
...ontrollers/datadogagent/controller_reconcile_v2.go 49.51% <31.03%> (-0.49%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f06176...542abe8. Read the comment docs.

@celenechang celenechang merged commit 70db137 into v1.6 May 1, 2024
15 of 20 checks passed
@celenechang celenechang deleted the celene/cherry-pick-1154 branch May 1, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants