Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM Onboarding] Use creation timestamp and UID of DatadogAgent as env vars for APM Telemetry KPIs (#1157) #1164

Merged
merged 1 commit into from
May 2, 2024

Conversation

fanny-jiang
Copy link
Contributor

What does this PR do?

Cherry-pick #1157

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

  • Agent: vX.Y.Z
  • Cluster Agent: vX.Y.Z

Describe your test plan

Write there any instructions and details you may have to test your PR.

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label

…v vars for APM Telemetry KPIs (#1157)

* Use UUID and timestamp generated during DatadogAgent installation

* Fix unit tests

* Use util functions

(cherry picked from commit 77d0df8)
@fanny-jiang fanny-jiang added enhancement New feature or request qa/skip-qa labels May 2, 2024
@fanny-jiang fanny-jiang added this to the v1.6.0 milestone May 2, 2024
@fanny-jiang fanny-jiang requested review from a team as code owners May 2, 2024 14:43
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 59.56%. Comparing base (70db137) to head (b5bda0b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             v1.6    #1164   +/-   ##
=======================================
  Coverage   59.56%   59.56%           
=======================================
  Files         174      174           
  Lines       21565    21565           
=======================================
  Hits        12845    12845           
  Misses       7941     7941           
  Partials      779      779           
Flag Coverage Δ
unittests 59.56% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ontrollers/datadogagent/component/agent/default.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70db137...b5bda0b. Read the comment docs.

@fanny-jiang fanny-jiang merged commit ac65f38 into v1.6 May 2, 2024
20 checks passed
@fanny-jiang fanny-jiang deleted the fanny/cherry-pick-1157 branch May 2, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qa/skip-qa
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants