Upgrade Go, controller-runtime and related dependencies #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levan-m
force-pushed
the
levan-m/controller-runtime-update
branch
from
ed9fbd4
to
b7c6e6b
Compare
…`make docker-build` fails on EDS checksum mismatch
levan-m
force-pushed
the
levan-m/controller-runtime-update
branch
from
b7c6e6b
to
24c0436
Compare
…rs passing. Updated CI go versions
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1175 +/- ##
==========================================
+ Coverage 59.55% 59.58% +0.02%
==========================================
Files 174 174
Lines 21559 21622 +63
==========================================
+ Hits 12839 12883 +44
- Misses 7941 7958 +17
- Partials 779 781 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
levan-m
force-pushed
the
levan-m/controller-runtime-update
branch
2 times, most recently
from
514993d
to
abebac8
Compare
levan-m
force-pushed
the
levan-m/controller-runtime-update
branch
from
abebac8
to
dd7b1c9
Compare
levan-m
commented
May 14, 2024
| // }, | ||
| // ObjectMeta: metav1.ObjectMeta{ | ||
| // Name: "test monitor", | ||
| // // https://github.com/kubernetes-sigs/controller-runtime/commit/7a66d580c0c53504f5b509b45e9300cc18a1cc30#diff-20ecedbf30721c01c33fb67d911da11c277e29990497a600d20cb0ec7215affdR683-R686 |
There was a problem hiding this comment.
FYI @celenechang, I couldn't find a quick workaround. Let me know if this is a blocker.
levan-m
changed the title
maycmlee
reviewed
May 14, 2024
| @@ -340,7 +342,7 @@ In the table, `spec.override.nodeAgent.image.name` and `spec.override.nodeAgent. | |||
| | [key].securityContext.seLinuxOptions.user | User is a SELinux user label that applies to the container. | | |||
| | [key].securityContext.seccompProfile.localhostProfile | localhostProfile indicates a profile defined in a file on the node should be used. The profile must be preconfigured on the node to work. Must be a descending path, relative to the kubelet's configured seccomp profile location. Must only be set if type is "Localhost". | | |||
| | [key].securityContext.seccompProfile.type | type indicates which kind of seccomp profile will be applied. Valid options are: Localhost - a profile defined in a file on the node should be used. RuntimeDefault - the container runtime default profile should be used. Unconfined - no profile should be applied. | | |||
| | [key].securityContext.supplementalGroups | A list of groups applied to the first process run in each container, in addition to the container's primary GID. If unspecified, no groups will be added to any container. Note that this field cannot be set when spec.os.name is windows. | | |||
| | [key].securityContext.supplementalGroups | A list of groups applied to the first process run in each container, in addition to the container's primary GID, the fsGroup (if specified), and group memberships defined in the container image for the uid of the container process. If unspecified, no additional groups are added to any container. Note that group memberships defined in the container image for the uid of the container process are still effective, even if they are not included in this list. Note that this field cannot be set when spec.os.name is windows. | | |||
There was a problem hiding this comment.
Suggested change
| | [key].securityContext.supplementalGroups | A list of groups applied to the first process run in each container, in addition to the container's primary GID, the fsGroup (if specified), and group memberships defined in the container image for the uid of the container process. If unspecified, no additional groups are added to any container. Note that group memberships defined in the container image for the uid of the container process are still effective, even if they are not included in this list. Note that this field cannot be set when spec.os.name is windows. | | |
| | [key].securityContext.supplementalGroups | A list of groups applied to the first process run in each container, in addition to the container's primary GID, the fsGroup (if specified), and group memberships defined in the container image for the UID of the container process. If unspecified, no additional groups are added to any container. **Note**: Group memberships defined in the container image for the UID of the container process are still effective, even if they are not included in this list. This field cannot be set when spec.os.name is Windows. | |
There was a problem hiding this comment.
Some of these nested types get docs from the dependent packages and we can't really modify it. This should come from here
https://github.com/kubernetes/api/blob/02024d286e48d744890214fa862cb7ec9df865af/core/v1/types.go#L3785-L3793
levan-m
force-pushed
the
levan-m/controller-runtime-update
branch
from
61b82f3
to
30616a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See CECO-1114 for details about specific changes.
v0.9.0-rc.2 -> v0.10.0-rc.4
sigs.k8s.io/controller-runtimev0.12.2 -> v0.16.0
k8s.io/api,k8s.io/apimachinery,k8s.io/client-go0.24.2 -> v0.28.9
go.uber.org/zapv1.19.1 -> 0.25.0
go1.19 -> 1.21
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Minimum Agent Versions
Are there minimum versions of the Datadog Agent and/or Cluster Agent required?
Describe your test plan
Write there any instructions and details you may have to test your PR.
Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel