Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoscaler references in DDM status to improve usability #118

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

Following @CharlyF feedback on DDM usability, adding a field to display autoscaler references

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

@vboulineau vboulineau requested a review from a team July 7, 2020 15:09
Copy link
Contributor

@CharlyF CharlyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elegant.

@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2020

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   58.18%   58.18%           
=======================================
  Files          31       31           
  Lines        4350     4350           
=======================================
  Hits         2531     2531           
  Misses       1631     1631           
  Partials      188      188           
Flag Coverage Δ
#unittests 58.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7eb70...23e28e1. Read the comment docs.

@vboulineau vboulineau merged commit 9c71245 into master Jul 9, 2020
@clamoriniere clamoriniere added this to the v0.3 milestone Aug 13, 2020
@clamoriniere clamoriniere added the bug Something isn't working label Aug 13, 2020
@vboulineau vboulineau deleted the vboulineau/ddm_improve branch October 28, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants