Update to operator-sdk 0.19.0 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vboulineau
force-pushed
the
vboulineau/operator-sdk
branch
3 times, most recently
from
7e6c296
to
cc3e239
Compare
vboulineau
force-pushed
the
vboulineau/operator-sdk
branch
from
cc3e239
to
4e385d2
Compare
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 58.21% 58.21%
=======================================
Files 31 31
Lines 4353 4353
=======================================
Hits 2534 2534
Misses 1630 1630
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
CharlyF
approved these changes
Aug 3, 2020
| @@ -48,7 +48,7 @@ spec: | |||
| args: | |||
| - --zap-level={{ .Values.logLevel }} | |||
| - --zap-encoder=console | |||
| # - --zap-stacktrace-level=error // TODO: uncomment after releasing v0.3.0 | |||
| # - --zap-stacktrace-level=panic // TODO: uncomment after releasing v0.3.0 | |||
There was a problem hiding this comment.
When will we remove the comment?
There was a problem hiding this comment.
When we release a new official Docker image (otherwise this parameter will break people using the chart with current official image)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update to operator-sdk 0.19.0 - finally fixing
--stacktrace-levelAdditional Notes
Anything else we should know when reviewing?