Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DatadogMetric CRD: references should be optional (will be filled by DCA 1.9+) #130

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

vboulineau
Copy link
Contributor

What does this PR do?

Make autoscalerReferences optional as it's not filled by DCA ATM (will require DCA 1.9+)

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

@vboulineau vboulineau requested a review from a team as a code owner August 7, 2020 10:17
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2020

Codecov Report

Merging #130 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   58.43%   58.43%           
=======================================
  Files          31       31           
  Lines        4376     4376           
=======================================
  Hits         2557     2557           
  Misses       1630     1630           
  Partials      189      189           
Flag Coverage Δ
#unittests 58.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7f1fc...bf692c2. Read the comment docs.

@vboulineau vboulineau merged commit eab4972 into master Aug 7, 2020
@clamoriniere clamoriniere added bug Something isn't working component/controller labels Aug 13, 2020
@clamoriniere clamoriniere added this to the v0.3 milestone Aug 13, 2020
@clamoriniere clamoriniere deleted the vboulineau/fix_ddm branch September 17, 2020 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants