Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syscalls needed for 7.22.0 version of system-probe #135

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

brycekahle
Copy link
Member

What does this PR do?

The new ebpf library we are using needs these additional syscalls. See DataDog/helm-charts#18 for corresponding update to the Helm chart.

Motivation

Without these syscalls, system-probe will CrashLoopBackoff.

@brycekahle brycekahle requested a review from a team as a code owner August 14, 2020 17:18
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation

@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2020

Codecov Report

Merging #135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   58.90%   58.90%           
=======================================
  Files          31       31           
  Lines        4441     4441           
=======================================
  Hits         2616     2616           
  Misses       1633     1633           
  Partials      192      192           
Flag Coverage Δ
#unittests 58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/datadogagent/systemprobe.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update deea430...de2812a. Read the comment docs.

@brycekahle brycekahle added the bug Something isn't working label Aug 14, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@clamoriniere clamoriniere added this to the v0.4 milestone Aug 14, 2020
@clamoriniere clamoriniere merged commit 4f2d252 into master Aug 28, 2020
@clamoriniere clamoriniere deleted the bryce.kahle/system-probe-seccomp-update branch August 28, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants