Generate V1 CRDs for Kube >=1.16 and fix v1beta1 for Kubernetes <= 1.15 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 58.90% 63.43% +4.53%
==========================================
Files 31 31
Lines 4441 5295 +854
==========================================
+ Hits 2616 3359 +743
- Misses 1633 1748 +115
+ Partials 192 188 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
vboulineau
changed the title
Co-authored-by: Cedric Lamoriniere <cedric.lamoriniere@datadoghq.com>
clamoriniere
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add generation of CRD v1 on top of CRD v1beta1 and fix v1beta1 issues with Kubernetes <= 1.16.
WIP: I am not sure how this is getting packaged by OLM.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?