CSV version 0.2.3 allowing agent (not operator) to use SCCs on OpenShift #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
deploy/clusterrole_binding.yaml
Outdated
| subjects: | ||
| - kind: ServiceAccount | ||
| name: datadog-agent-scc | ||
| namespace: default |
There was a problem hiding this comment.
Suggested change
| namespace: default | |
| namespace: default | |
deploy/service_account.yaml
Outdated
| apiVersion: v1 | ||
| kind: ServiceAccount | ||
| metadata: | ||
| name: datadog-agent-scc |
There was a problem hiding this comment.
Suggested change
| name: datadog-agent-scc | |
| name: datadog-agent-scc | |
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
=======================================
Coverage 58.02% 58.02%
=======================================
Files 31 31
Lines 4610 4610
=======================================
Hits 2675 2675
Misses 1739 1739
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
vboulineau
force-pushed
the
vboulineau/fix_scc_usage
branch
from
f7222f4
to
1e3ab13
Compare
clamoriniere
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?