Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system-probe] Update seccomp profile and capabilities for system probe #140

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

xornivore
Copy link
Contributor

What does this PR do?

Updates the seccomp profile with missing syscalls and adds NET_BROADCAST capability for the system probe.

This closely matches what we have currently in the helm chart.

Motivation

With the latest Agent image 7.22.0 the system probe fails start due to missing calls in the seccomp profile.

2020-08-27 20:39:33 UTC | SYS-PROBE | ERROR | (cmd/system-probe/loader.go:39 in Register) | new module `network_tracer` error: %!w(*errors.errorString=&{error guessing offsets: could not load bpf module for offset guessing: read /opt/datadog-agent/embedded/share/system-probe/ebpf/offset-guess.o: operation not permitted})

Additional Notes

Anything else we should know when reviewing?

System probe fails start due to missing calls in the seccomp profile with Agent 7.22.0.

This matches what we have currently in the helm chart.
@xornivore xornivore added bug Something isn't working component/controller labels Aug 28, 2020
@xornivore xornivore added this to the v0.3 milestone Aug 28, 2020
@xornivore xornivore requested a review from a team August 28, 2020 02:23
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #140   +/-   ##
=======================================
  Coverage   58.02%   58.02%           
=======================================
  Files          31       31           
  Lines        4610     4610           
=======================================
  Hits         2675     2675           
  Misses       1739     1739           
  Partials      196      196           
Flag Coverage Δ
#unittests 58.02% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/datadogagent/systemprobe.go 100.00% <ø> (ø)
pkg/controller/datadogagent/utils.go 83.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b8bf72...411c041. Read the comment docs.

@clamoriniere clamoriniere merged commit d00b468 into master Aug 28, 2020
@clamoriniere clamoriniere deleted the xornivore/update-system-probe-seccomp branch August 28, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants